On 13-06-17, 14:58, Tomasz Wilczynski wrote: > This is my first patch so please bare with me...
No worries, we were just telling you about what's the right way.. > I am just a little > confused. Does this mean that it is all right to leave the patch as it is, > or should I still add the Fixes: tag and resubmit it? Rafael has already applied the patch with all the required tags (look in the PM tree): commit b8e11f7d2791bd9320be1c6e772a60b2aa093e45 Author: Tomasz Wilczyński <[email protected]> Date: Sun Jun 11 17:28:39 2017 +0900 cpufreq: conservative: Allow down_threshold to take values from 1 to 10 Commit 27ed3cd2ebf4 (cpufreq: conservative: Fix the logic in frequency decrease checking) removed the 10 point substraction when comparing the load against down_threshold but did not remove the related limit for the down_threshold value. As a result, down_threshold lower than 11 is not allowed even though values from 1 to 10 do work correctly too. The comment ("cannot be lower than 11 otherwise freq will not fall") also does not apply after removing the substraction. For this reason, allow down_threshold to take any value from 1 to 99 and fix the related comment. Fixes: 27ed3cd2ebf4 (cpufreq: conservative: Fix the logic in frequency decrease checking) Signed-off-by: Tomasz Wilczyński <[email protected]> Acked-by: Viresh Kumar <[email protected]> Cc: 3.10+ <[email protected]> # 3.10+ Signed-off-by: Rafael J. Wysocki <[email protected]> --- drivers/cpufreq/cpufreq_conservative.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- viresh
