On 8 June 2017 at 09:55, Dietmar Eggemann <[email protected]> wrote: > This patch prepares the actual implementation of the frequency-invariant > load-tracking support provided in the next patch ("drivers > base/arch_topology: frequency-invariant load-tracking support"). > > The maximum supported frequency of a cpu (policy->cpuinfo.max_freq) has > to be retrieved for frequency-invariant load-tracking. > > This can be achieved by coding this functionality into the existing > cpufreq policy notifier (init_cpu_capacity_notifier) which is currently > only used for setting up dt-based cpu capacities (cpu node property > capacity-dmips-mhz). > > But frequency-invariant load-tracking has to work whether cpu capacity > dt-parsing succeeded or not. > > Change init_cpu_capacity_notifier in such a way that even if the parsing > of the cpu capacity information failed the notifier is called for each > cpufreq policy to be able to set the maximum supported frequency. > > The exit condition in register_cpufreq_notifier() now only tests for > !acpi_disabled because for frequency invariance the cpufreq policy > notifier has to be enabled even if u32 *raw_capacity is NULL which > occurs when there is no capacity-dmips-mhz property in the dt file or > when the allocation for raw_capacity[cpu] has failed. > > The continue statement in init_cpu_capacity_callback() makes sure that > we don't go on calculating capacity_scale in case the capacity parsing > failed. It should be a break rather a continue here but the next patch > introduces code to set the per-cpu variable max_freq in this > for_each_cpu loop before the check if cap_parsing_failed so it has to > be a continue. > > Cc: Catalin Marinas <[email protected]> > Cc: Will Deacon <[email protected]> > Cc: Russell King <[email protected]> > Cc: Greg Kroah-Hartman <[email protected]> > Cc: Juri Lelli <[email protected]> > Signed-off-by: Dietmar Eggemann <[email protected]>
Acked-by: Vincent Guittot <[email protected]>
