Re: [PATCH v2] signal: Avoid undefined behaviour in kill_something_info

[zhong jiang]

On 2017/6/5 21:31, Oleg Nesterov wrote:
> On 06/05, zhongjiang wrote:
>> --- a/kernel/signal.c
>> +++ b/kernel/signal.c
>> @@ -1395,6 +1395,12 @@ static int kill_something_info(int sig, struct 
>> siginfo *info, pid_t pid)
>>
>>      read_lock(&tasklist_lock);
>>      if (pid != -1) {
>> +            /*
>> +             * -INT_MIN is undefined, it need to exclude following case to
>> +             * avoid the UBSAN detection.
>> +             */
>> +            if (pid == INT_MIN)
>> +                    return -ESRCH;
> you need to do this before read_lock(tasklist)
>
> Oleg.
>
>
> .
>
  I am so sorry for disturbing.

 Thanks
zhongjiang