On 05/22/17 18:27, Olof Johansson wrote: > Hi, > > > On Mon, May 22, 2017 at 5:41 PM, Palmer Dabbelt <[email protected]> wrote: >> --- >> arch/riscv/.gitignore | 35 ++++ >> arch/riscv/Kconfig | 300 >> +++++++++++++++++++++++++++++++++++ >> arch/riscv/Makefile | 64 ++++++++ >> arch/riscv/configs/riscv32_spike | 47 ++++++ >> arch/riscv/configs/riscv64_freedom-u | 52 ++++++ >> arch/riscv/configs/riscv64_qemu | 64 ++++++++ >> arch/riscv/configs/riscv64_spike | 45 ++++++ >> 7 files changed, 607 insertions(+) >> create mode 100644 arch/riscv/.gitignore >> create mode 100644 arch/riscv/Kconfig >> create mode 100644 arch/riscv/Makefile >> create mode 100644 arch/riscv/configs/riscv32_spike >> create mode 100644 arch/riscv/configs/riscv64_freedom-u >> create mode 100644 arch/riscv/configs/riscv64_qemu >> create mode 100644 arch/riscv/configs/riscv64_spike > > Nearly all other platforms have _defconfig in the config names. It > might get a bit excessive to prepend riscv{32,64} to all of them > though. Most other platforms have shortened it to, for example, > spike_defconfig, spike64_defconfig, qemu_defconfig, > freedom-u_defconfig. > > Not going to argue too much about the color of the shed here, but > using the _defconfig naming is recommended.
well, the top-level Makefile looks for "make *config" to indicate that there is a config-command in progress (or in process), so they usually have to end in the string "config". Have these been tested? -- ~Randy
