Hi Al, I couldn't easily find this patch series posted anywhere (I didn't try too hard) so I sill just comment here. I first noticed them in the vfs tree in linux-next today.
Overall, I like what they day, but when I first created kernel/compat.c (in 2002), Linus did not want the compat code sprinkled all over the other files (due to the uglifiying effect of #ifdefs in the C code, and because the compat layer was only secondary). He may have changed his mind since then, but it is worth asking. The cleanups (including more static functions) make it worth while for me, at least. It also might have been worth asking the original (and subsequent) authors of the code for review and/or comments. One thing I noticed from a quick look: do_handle_open() could now be static. -- Cheers, Stephen Rothwell
