On 02/17/2017 11:08 PM, Alexey Khoroshilov wrote: > hisi_spi_nor_probe() ignores clk_prepare_enable() error code. > The patch fixes that. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <[email protected]>
Acked-by: Marek Vasut <[email protected]> > --- > drivers/mtd/spi-nor/hisi-sfc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/hisi-sfc.c b/drivers/mtd/spi-nor/hisi-sfc.c > index 20378b0d55e9..a286350627a6 100644 > --- a/drivers/mtd/spi-nor/hisi-sfc.c > +++ b/drivers/mtd/spi-nor/hisi-sfc.c > @@ -448,8 +448,11 @@ static int hisi_spi_nor_probe(struct platform_device > *pdev) > if (!host->buffer) > return -ENOMEM; > > + ret = clk_prepare_enable(host->clk); > + if (ret) > + return ret; > + > mutex_init(&host->lock); > - clk_prepare_enable(host->clk); > hisi_spi_nor_init(host); > ret = hisi_spi_nor_register_all(host); > if (ret) > -- Best regards, Marek Vasut
