On Wed, 14 Mar 2007, Benjamin LaHaise wrote: > On Wed, Mar 14, 2007 at 03:19:21PM -0700, Davide Libenzi wrote: > > + /* > > + * Check if the user asked us to deliver the result through an > > + * asyncfd. Note that asyncfd_add_results() may sleep. It seems > > + * OK looking at the code, but I'm not sure since inside a USB driver, > > + * aio_complete() is called with a spinlock held. !!CHECK > > + */ > > That won't work. aio_complete() is supposed to be irq safe.
Can you point me to a kernel path that ends up calling aio_complete() in a do-not-sleep mode? The offender I see is drivers/usb/gadget/inode.c that calls it with a spinlock held. The aio_run_iocb function seem to release/reacquire the lock before calling aio_complete(). - Davide - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
