On Wed, Jan 18, 2017 at 03:11:24PM +0100, Vlastimil Babka wrote:
> Since commit be97a41b291e ("mm/mempolicy.c: merge alloc_hugepage_vma to
> alloc_pages_vma") alloc_pages_vma() can potentially free a mempolicy by
> mpol_cond_put() before accessing the embedded nodemask by
> __alloc_pages_nodemask(). The commit log says it's so "we can use a single
> exit path within the function" but that's clearly wrong. We can still do that
> when doing mpol_cond_put() after the allocation attempt.
>
> Make sure the mempolicy is not freed prematurely, otherwise
> __alloc_pages_nodemask() can end up using a bogus nodemask, which could lead
> e.g. to premature OOM.
>
> Fixes: be97a41b291e ("mm/mempolicy.c: merge alloc_hugepage_vma to
> alloc_pages_vma")
> Signed-off-by: Vlastimil Babka <[email protected]>
> Cc: [email protected]
> Cc: Aneesh Kumar K.V <[email protected]>
> Cc: Kirill A. Shutemov <[email protected]>
> Cc: David Rientjes <[email protected]>
> Cc: Andrea Arcangeli <[email protected]>
Looks good to me.
Acked-by: Kirill A. Shutemov <[email protected]>
--
Kirill A. Shutemov
