On Sat, Dec 31, 2016 at 06:11:13AM +0530, [email protected] wrote: > From: Gideon Israel Dsouza <[email protected]> > > Very sorry about the previous broken patch. Here is an updated one. > > I submitted 4 total patches. They are part of task I've taken up to > increase compiler portability in the kernel. I've cleaned up the > subsystems under /kernel /mm /block and /security, this patch targets > /crypto. > > There is <linux/compiler.h> which provides macros for various gcc specific > constructs. Eg: __weak for __attribute__((weak)). I've cleaned all > instances of gcc specific attributes with the right macros for the crypto > subsystem. > > I had to make one additional change into compiler-gcc.h for the case when > one wants to use this: __attribute__((aligned) and not specify an alignment > factor. From the gcc docs, this will result in the largest alignment for > that data type on the target machine so I've named the macro > __aligned_largest. Please advise if another name is more appropriate. > > RFC: There are many places where __attribute((unused)) is used. There are > two macros for the exact same macro inside compiler-gcc.h: > __always_unused and __maybe_unused. I'm not sure which to have used to > replace instances inside /crypto. Should there perhaps be just an unused > macro. There are 1830 instances of __maybe_unused inside the kernel > code and 110 uses of__always_unused excluding my changes. > > Signed-off-by: Gideon Israel Dsouza <[email protected]>
Please send crypto patches to [email protected]. > static void crypto_ablkcipher_show(struct seq_file *m, struct crypto_alg > *alg) > - __attribute__ ((unused)); > + __always_unused; You should use __maybe_unused. Cheers, -- Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
