> >  #include <dt-bindings/pinctrl/samsung.h>
> >  
> > -#define PIN_PULL_NONE              0
> > -#define PIN_PULL_DOWN              1
> > -#define PIN_PULL_UP                3
> > -
> > -#define PIN_DRV_LV1                0
> > -#define PIN_DRV_LV2                2
> > -#define PIN_DRV_LV3                1
> > -#define PIN_DRV_LV4                3
> > -
> > -#define PIN_IN                     0
> > -#define PIN_OUT                    1
> > -#define PIN_FUNC1          2
> > -
> 
> This should be squashed with 3/4 because logically it is strictly
> related to it and splitting it does not bring any benefits. Actually
> while looking at 3/4 I was surprised to see them not removed.

Yes, right :)

Thanks,
Andi

Reply via email to