On 2016/8/18 1:20, Al Viro wrote: > On Tue, Aug 16, 2016 at 03:46:22PM +0800, zijun_hu wrote: >> From: zijun_hu <[email protected]> >> >> move out get_count_order[_long]() definitions from scope limited >> by macro __KERNEL__ >> >> it not only make both functions available in wider region regardless >> of whether __KERNEL__ is defined but also keep original region for >> get_count_order() before the recent commit c513b4cd2fe9 >> ("mm-vmalloc-fix-align-value-calculation-error-v2-fix-fix") > > What the hell is anything without __KERNEL__ doing with linux/bitops.h in > the first place? IOW, why do we have those ifdefs at all? >
__KERNEL__ is used to indicate the relevant sections within kernel headers can't be exported to or used by user space let me illuminate this patch background firstly i and Andrew develop another patch to fix a mm issue recently, that patch move get_count_order() into __KERNEL__ scope, so touch the function's scope property we don't need to touch or care the aim of this patch is undoing our unnecessary changes
