On Mon, Aug 15, 2016 at 05:25:43PM +0100, Colin King wrote: > From: Colin Ian King <[email protected]> > > map is being already checked if it is null at the start of > do_zoom_dso, so the second subsequent check is superfluous > and can be removed. > > Signed-off-by: Colin Ian King <[email protected]>
Acked-by: Namhyung Kim <[email protected]> Thanks, Namhyung > --- > tools/perf/ui/browsers/hists.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c > index 13d4143..8d72939 100644 > --- a/tools/perf/ui/browsers/hists.c > +++ b/tools/perf/ui/browsers/hists.c > @@ -2418,8 +2418,6 @@ do_zoom_dso(struct hist_browser *browser, struct > popup_action *act) > browser->hists->dso_filter = NULL; > ui_helpline__pop(); > } else { > - if (map == NULL) > - return 0; > ui_helpline__fpush("To zoom out press ESC or ENTER + \"Zoom out > of %s DSO\"", > __map__is_kernel(map) ? "the Kernel" : > map->dso->short_name); > browser->hists->dso_filter = map->dso; > -- > 2.8.1 >
