I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro.
Signed-off-by: Chuansheng Liu <[email protected]> Signed-off-by: Baole Ni <[email protected]> --- drivers/edac/edac_module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/edac/edac_module.c b/drivers/edac/edac_module.c index 5f8543b..54009fa 100644 --- a/drivers/edac/edac_module.c +++ b/drivers/edac/edac_module.c @@ -39,7 +39,7 @@ int edac_debug_level = 2; EXPORT_SYMBOL_GPL(edac_debug_level); module_param_call(edac_debug_level, edac_set_debug_level, param_get_int, - &edac_debug_level, 0644); + &edac_debug_level, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(edac_debug_level, "EDAC debug level: [0-4], default: 2"); #endif -- 2.9.2
