Am 18.06.2016 um 13:34 schrieb Boris Brezillon: > On Sat, 18 Jun 2016 11:23:01 +0200 > Richard Weinberger <[email protected]> wrote: > >> diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c >> index 55f3ab8..aadebe7 100644 >> --- a/drivers/mtd/nand/nand_base.c >> +++ b/drivers/mtd/nand/nand_base.c >> @@ -3703,6 +3703,10 @@ static int nand_detect(struct nand_chip *chip, struct >> nand_flash_dev *type) >> >> chip->manufacturer.ops = nand_manuf_ids[maf_idx].ops; >> >> + if (!chip->manufacturer.ops) >> + /* assign no operations */ >> + chip->manufacturer.ops = nand_manuf_ids[0].ops; >> + > > BTW, this is wrong, the manufacturer id code is not the index of the > nand_manuf_ids[] table ;). If we go for this option, we should probably > declare no_ops in nand_base.c and assign it here: >
Oh, yes. You are right. Anyway, I think having a wrapper is also a good solution. Thanks, //richard
