2016-05-04 3:46 GMT+08:00 Matt Fleming <[email protected]>: > If we're accessing rq_clock() (e.g. in sched_avg_update()) we should > update the rq clock before calling cpu_load_update(), otherwise any > time calculations will be stale. > > All other paths currently call update_rq_clock(). > > Cc: Peter Zijlstra <[email protected]> > Cc: Ingo Molnar <[email protected]> > Cc: Mike Galbraith <[email protected]> > Cc: Mel Gorman <[email protected]> > Cc: Thomas Gleixner <[email protected]> > Cc: Frederic Weisbecker <[email protected]> > Cc: Rik van Riel <[email protected]> > Signed-off-by: Matt Fleming <[email protected]>
Reviewed-by: Wanpeng Li <[email protected]> > --- > kernel/sched/fair.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index b8a33abce650..aa9ba82f0d7c 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -4723,6 +4723,7 @@ void cpu_load_update_nohz_stop(void) > > load = weighted_cpuload(cpu_of(this_rq)); > raw_spin_lock(&this_rq->lock); > + update_rq_clock(this_rq); > cpu_load_update_nohz(this_rq, curr_jiffies, load); > raw_spin_unlock(&this_rq->lock); > } > -- > 2.7.3 > -- Regards, Wanpeng Li
