On 04/23, Frank Rowand wrote: > From: Frank Rowand <[email protected]> > > Failure to enable DMA by the msm_serial driver is silent. > Add a message to report the failure. > > Signed-off-by: Frank Rowand <[email protected]> > --- > drivers/tty/serial/msm_serial.c | 1 + > 1 file changed, 1 insertion(+) > > Index: b/drivers/tty/serial/msm_serial.c > =================================================================== > --- a/drivers/tty/serial/msm_serial.c > +++ b/drivers/tty/serial/msm_serial.c > @@ -170,6 +170,7 @@ rel_tx: > dma_release_channel(dma->chan); > no_tx: > memset(dma, 0, sizeof(*dma)); > + dev_info(dev, "msm_serial: DMA not enabled\n"); > } >
Wouldn't this print twice for TX and RX channels? I'd prefer we not print anything when this driver probes, just because it's a bunch of log spam that we don't really need. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
