> -----Original Message----- > From: Jonathan Cameron [mailto:[email protected]] > Sent: 16 April, 2016 22:20 > To: Alison Schofield > Cc: [email protected]; [email protected]; [email protected]; [email protected]; > [email protected]; linux- > [email protected]; [email protected]; > [email protected]; [email protected]; > Srinivas Pandruvada; Tirdea, Irina > Subject: Re: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct > device > > On 10/04/16 20:05, Alison Schofield wrote: > > Driver includes struct regmap and struct device in its global data. > > Remove the struct device and use regmap API to retrieve device info. > > > > Patch created using Coccinelle plus manual edits. > > > > Signed-off-by: Alison Schofield <[email protected]> > I'm happy with this but please do make sure to cc the maintainer / author > of drivers if possible (often the email addresses are out of date!) > > Srinivas, this is one of yours. Are you happy with this? > I've also cc'd Irina who has worked on this driver recently for any > comments. >
Looks good to me. Reviewed-by: Irina Tirdea <[email protected]> Alison, I think bmc150_magn driver qualifies for this change as well after Daniel's patches got merged [1]. Thanks, Irina [1] https://lkml.org/lkml/2016/4/15/407 > If no one comments in the meantime I'll probably pick these up sometime > in the next week. > > Jonathan
