On Tue, 22 Mar 2016 09:14:14 -0400 Peter Xu <[email protected]> wrote:
> This line is useless since we will get more verbose info in > do_connection(). Another problem is, we will get this "connected!" line > everytime after we hit "ctrl-c" for "trace-cmd listen". We possibly do > not want that. > > Signed-off-by: Peter Xu <[email protected]> > --- > trace-listen.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/trace-listen.c b/trace-listen.c > index 1e38eda..12cc9c5 100644 > --- a/trace-listen.c > +++ b/trace-listen.c > @@ -721,7 +721,6 @@ static void do_accept_loop(int sfd) > do { > cfd = accept(sfd, (struct sockaddr *)&peer_addr, > &peer_addr_len); > - printf("connected!\n"); I probably kept this in for debugging. But I still think there should be some kind of logging here. If anything, change this to a debug print. I'm working on passing in --debug into the command line here, so I'm not going to take this patch. It should be converted to the debug coed. -- Steve > if (cfd < 0 && errno == EINTR) > continue; > if (cfd < 0)
