On Sun, Jan 03, 2016 at 07:20:40PM +0200, Jarkko Sakkinen wrote: > On Thu, Dec 17, 2015 at 11:23:15AM -0700, Jason Gunthorpe wrote: > > Instead of clearing the global interrupts flag when any device > > does not have an interrupt just pass -1 through tpm_info.irq. > > > > The only thing that asks for autoprobing is the force=1 path. > > Sorry for my ignorance but what does this patch help? Why interrupts > flag is not enough?
It is wrong for a driver's probe function to change global state, and very wrong to change a module option. > > Signed-off-by: Jason Gunthorpe <[email protected]> > > Tested-by: Wilck, Martin <[email protected]> > > Tested-by: Jarkko Sakkinen <[email protected]> > > Did I already give Tested-by's for this series (I did for those that > went into v4.5 pull request)? You said you tested the crb stuff, which is this series... Did you test something else? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
