Tomi Valkeinen <[email protected]> writes: > On 07/12/15 22:50, Robert Jarzmik wrote: > >>> It seems that at least "depth" is missing from the binding document. >> You're right. >> >> Actually depth is not a "hardware" caracteristic. Moreover it's just used as >> an >> overlay for pxafb_set_pixfmt() to superseed var->bits_per_pixel. I'm >> wondering >> if the right path for of_get_pxafb_mode_info() would be to remove completely >> depth, and leave it initialized at 0 for the DT case. >> >> What do you think of this approach ? The other one would be to modify the >> binding, and yet I feel this depth doesn't belong to the binding, it's my >> patch >> which requires another spin IMHO. > > Yes, we should avoid non-hardware relate properties in the .dts files if > at all possible. If the driver works fine without the property, I think > it's fine to remove it. If it is required it needs to be added to the > binding document.
Ok, agreed Tomi. That commits me for a v6, as the driver works fine on my tests. I'll send it in the next couple of days. Thanks for the review. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
