>From: Wang Nan [mailto:[email protected]] > >There's a mistake in dso__adjust_kmod_long_name() that, it use strdup() >to dup the new long_name of a dso, but passes the original string >to dso__set_long_name(). Which causes random crash during cleanup. >
Looks good to me:) Reviewed-by: Masami Hiramatsu <[email protected]> Thanks! >Fixes: c03d5184f0e9("perf machine: Adjust dso->long_name for offline module") >Signed-off-by: Wang Nan <[email protected]> >Cc: Arnaldo Carvalho de Melo <[email protected]> >Cc: Masami Hiramatsu <[email protected]> >Cc: Namhyung Kim <[email protected]> >Cc: Zefan Li <[email protected]> >Cc: [email protected] >--- > tools/perf/util/machine.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c >index 95a7f60..bfc289c 100644 >--- a/tools/perf/util/machine.c >+++ b/tools/perf/util/machine.c >@@ -576,7 +576,7 @@ static void dso__adjust_kmod_long_name(struct dso *dso, >const char *filename) > if (!dup_filename) > return; > >- dso__set_long_name(dso, filename, true); >+ dso__set_long_name(dso, dup_filename, true); > } > > struct map *machine__findnew_module_map(struct machine *machine, u64 start, >-- >1.8.3.4 N�����r��y����b�X��ǧv�^�){.n�+����{����zX����ܨ}���Ơz�&j:+v�������zZ+��+zf���h���~����i���z� �w���?�����&�)ߢf��^jǫy�m��@A�a��� 0��h���i
