On Mon, 16 Nov 2015 15:33:10 -0500 Steven Rostedt <[email protected]> wrote:
> When a long value is read on 32 bit machines for 64 bit output, the parsing > needs to change "%lu" into "%llu", as the value is read natively. > > Unfortunately, if "%llu" is already there, the code will add another "l" to > it and fail to parse it properly. > > Cc: [email protected] > Signed-off-by: Steven Rostedt <[email protected]> > --- > tools/lib/traceevent/event-parse.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/traceevent/event-parse.c > b/tools/lib/traceevent/event-parse.c > index 4d885934b919..43e202bb3ae3 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -4895,7 +4895,7 @@ static void pretty_print(struct trace_seq *s, void > *data, int size, struct event > break; > } > } > - if (pevent->long_size == 8 && ls && > + if (pevent->long_size == 8 && ls == 1 && Bah, this breaks %p when reading on 32bit. Update patch coming -- Steve > sizeof(long) != 8) { > char *p; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
