On Thu, 22 Oct 2015, Moritz Fischer wrote: Hi Moritz,
Thank you, yes this is better. I don't know if I need to ack everything, but here it is anyway: Acked-by: Alan Tull <[email protected]> Alan > The return value should be checked for non-zero, instead > of checking it being IS_ERR_VALUE(). > > Signed-off-by: Moritz Fischer <[email protected]> > --- > drivers/fpga/socfpga.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c > index 706b80d..27d2ff2 100644 > --- a/drivers/fpga/socfpga.c > +++ b/drivers/fpga/socfpga.c > @@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device > *pdev) > > ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0, > dev_name(dev), priv); > - if (IS_ERR_VALUE(ret)) > + if (ret) > return ret; > > return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager", > -- > 2.4.3 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
