On Wed, Oct 14, 2026 at 04:01:12PM -0400, Sasha Levin wrote:
> The arm64 suite builds and installs its subdirectories in shell loops
> whose status is that of the last subdirectory. A failure in an earlier
> subdirectory is therefore lost unless FORCE_TARGETS is set, while a
> failure in the last one fails "make all" and, through "install: all",
> drops the installation of every other arm64 test as well.
> 
> Make each loop fail only when no subdirectory succeeds, which matches
> how the top-level selftests Makefile treats its targets, and keep
> stopping at the first failure when FORCE_TARGETS is set. When a build
> report is requested, record each subdirectory as arm64/<subdir> so that
> a partially built suite is visible even though make succeeds.
> 
> Invoke the subdirectories with $(MAKE) rather than make. The command
> line variables already reach them through MAKEFLAGS either way, but
> $(MAKE) lets them use the parent's jobserver and makes -n, -t and -q
> apply to them.
> 
> Fixes: 313a4db7f338 ("kselftest: arm64: extend toplevel skeleton Makefile")
> Signed-off-by: Sasha Levin <[email protected]>

Acked-by: Catalin Marinas <[email protected]>

Sashiko had a comment about breakage ARM64_SUBTARGETS is empty. I think
it's a false positive but I didn't check.

Reply via email to