On 14/10/2026 22:56, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] mptcp_join.sh init() now calls `mptcp_lib_check_tools ip tc ss
> nft` (mptcp_join.sh:192).
TL;DR not an issue.
> --
>
> selftests: mptcp: convert iptables to nftables for mptcp_join.sh
>
> This converts the iptables/ip6tables rules in mptcp_join.sh to nftables.
> The cBPF bytecode matches are replaced with native nft matching, and
> hard-coded offsets are used for RM_ADDR. The config file is updated to
> match, and the iptables/ip6tables tool check is removed from
> mptcp_lib.sh.
>
>> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh
>> b/tools/testing/selftests/net/mptcp/mptcp_join.sh
>> index 18ce7136a2b0e..f4d8afaeda4f3 100755
>> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
>> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
>
> [ ... ]
>
>> @@ -196,7 +189,7 @@ init() {
>>
>> mptcp_lib_check_mptcp
>> mptcp_lib_check_kallsyms
>> - mptcp_lib_check_tools ip tc ss "${iptables}" "${ip6tables}"
>> + mptcp_lib_check_tools ip tc ss nft
>
> [Severity: Medium]
> Will this skip the whole mptcp_join.sh suite when nft has no JSON
> support?
Yes, but really, who has nft without JSON support? If a CI doesn't have
that, better to skip everything to be clear that something important is
missing instead of just skipping some subtests which might be unnoticed.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
