The direct path is not supported on verity files. Attempts to use direct
I/O path on such files should fall back to buffered I/O path.

Signed-off-by: Andrey Albershteyn <[email protected]>
[djwong: fix braces]
Signed-off-by: Darrick J. Wong <[email protected]>
---
 fs/xfs/xfs_file.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index a980ac5196a8..6fa9835f9531 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -282,7 +282,8 @@ xfs_file_dax_read(
        struct kiocb            *iocb,
        struct iov_iter         *to)
 {
-       struct xfs_inode        *ip = XFS_I(iocb->ki_filp->f_mapping->host);
+       struct inode            *inode = iocb->ki_filp->f_mapping->host;
+       struct xfs_inode        *ip = XFS_I(inode);
        ssize_t                 ret = 0;
 
        trace_xfs_file_dax_read(iocb, to);
@@ -333,6 +334,14 @@ xfs_file_read_iter(
        if (xfs_is_shutdown(mp))
                return -EIO;
 
+       /*
+        * In case fs-verity is enabled, we also fallback to the buffered read
+        * from the direct read path. Therefore, IOCB_DIRECT is set and need to
+        * be cleared (see generic_file_read_iter())
+        */
+       if (fsverity_active(inode))
+               iocb->ki_flags &= ~IOCB_DIRECT;
+
        if (IS_DAX(inode))
                ret = xfs_file_dax_read(iocb, to);
        else if (iocb->ki_flags & IOCB_DIRECT)
-- 
2.51.2



_______________________________________________
Linux-f2fs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Reply via email to