Hi Krzysztof,
On Sat, Nov 25, 2023 at 7:44 PM Krzysztof Kozlowski
<[email protected]> wrote:
> Document preferred coding style for Devicetree sources (DTS and DTSI),
> to bring consistency among all (sub)architectures and ease in reviews.
>
> Cc: Andrew Davis <[email protected]>
> cc: Andrew Lunn <[email protected]>
> Cc: AngeloGioacchino Del Regno <[email protected]>
> Cc: Arnd Bergmann <[email protected]>
> Cc: Bjorn Andersson <[email protected]>
> Cc: Chen-Yu Tsai <[email protected]>
> Cc: Dmitry Baryshkov <[email protected]>
> Cc: Geert Uytterhoeven <[email protected]>
> Cc: Heiko Stuebner <[email protected]>
> Cc: Jonathan Corbet <[email protected]>
> Cc: Konrad Dybcio <[email protected]>
> Cc: Matthias Brugger <[email protected]>
> Cc: Michal Simek <[email protected]>
> Cc: Neil Armstrong <[email protected]>
> Cc: Nishanth Menon <[email protected]>
> Cc: Olof Johansson <[email protected]>
> Cc: Rafał Miłecki <[email protected]>
> Acked-by: Neil Armstrong <[email protected]>
> Acked-by: Heiko Stuebner <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Merging idea: Rob/DT bindings
>
> Changes in v3
> =============
> 1. should->shall (Angelo)
> 2. Comments // -> /* (Angelo, Michal)
> 3. Use imaginary example in "Order of Properties in Device Node"
> (Angelo)
> 4. Added paragraphs for three sections with justifications of chosen
> style.
> 5. Allow two style of ordering overrides in board DTS: alphabetically or
> by order of DTSI (Rob).
> 6. I did not incorporate feedback about, due to lack of consensus and my
> disagreement:
> a. SoM being DTS without DTSI in "Organizing DTSI and DTS"
Thanks for the update!
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dts-coding-style.rst
> + /* SoC DTSI */
> +
> + / {
> + cpus {
> + /* ... */
> + };
> +
> + psci {
> + /* ... */
> + };
> +
> + soc@ {
"soc@" is invalid, that should be "soc".
As the "soc" node is special, you may want to elaborate:
compatible = "simple-bus";
#address-cells = <1>;
#size-cells = <1>;
ranges;
> + dma: dma-controller@10000 {
> + /* ... */
> + };
> +
> + clk: clock-controller@80000 {
> + /* ... */
> + };
> + };
> + };
> +
> + /* Board DTS - alphabetical order */
> +
> + &clk {
> + /* ... */
> + };
> +
> + &dma {
> + /* ... */
> + };
> +
> + /* Board DTS - alternative order, keep as DTSI */
> +
> + &dma {
> + /* ... */
> + };
> +
> + &clk {
> + /* ... */
> + };
IMO that alternative order is hard to review: you need to have multiple
files open. It will also make validation hard, as you can only validate
the end result, not individual files.
Anyway, this is already quite usable so
Reviewed-by: Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
