On Wed, Dec 10, 2025 at 09:36:06AM +0800, Bibo Mao wrote: > > > On 2025/12/10 上午7:25, Eric Biggers wrote: > > On Tue, Dec 09, 2025 at 10:22:58AM +0800, Bibo Mao wrote: > > > ECB AES also is added here, its ivsize is zero and name is different > > > compared with CBC AES algo. > > > > What is the use case for this feature?Currently qemu builtin backend and > > openssl afalg only support CBC AES, > it depends on modified qemu and openssl to test this. > > Maybe this patch adding ECB AES algo can be skipped now, it is just an > example, the final target is to add SM4 cipher.
There's no need to add useless features. The title of your patchset is "crypto: virtio: Add ecb aes algo support". So it sounds like the main point of your patchset is to add a useless feature? If there are actually unrelated fixes you want, you should send those separately. As for SM4 support (which mode?), if you really want that (you shouldn't), why not use the existing CPU accelerated implementation? - Eric
