On Fri, Jun 27, 2025 at 02:46:11PM +0800, Qunqin Zhao wrote: > > 在 2025/6/27 上午2:29, Jarkko Sakkinen 写道: > > On Thu, Jun 26, 2025 at 08:48:35PM +0800, Huacai Chen wrote: > > > But there is another coherency, you can see this in the 1st patch: > > > > > > +static const struct mfd_cell engines[] = { > > > + { .name = "loongson-rng" }, > > > + { .name = "loongson-tpm" }, > > > +}; > > I thought already after ffa driver from ARM that I need to fix up > > the naming a bit before it explodes. Thus, I'll stick to this. > > > > And e.g., I could easily find DRM driver with opposite order. > Next revision: > > +static const struct mfd_cell engines[] = { > + { .name = "loongson-rng" }, > + { .name = "tpm_loongson" }, > +}; > Then > "loongson-rng" can match MFD and Crypto subsystem naming convention. > "tpm_loongson" can match TPM subsystem naming convention.
Great, this works for me. Thank you, appreciate it! > > > Thanks, > Qunqin > > > > Huacai > > BR, Jarkko > BR, Jarkko