For SEV tests, assert() failures on VM type or fd do not provide
sufficient error reporting. Replace assert() with TEST_ASSERT_EQ() to
obtain more detailed information on the assertion condition failure,
including the call stack.

Signed-off-by: Pratik R. Sampat <prsam...@amd.com>
---
v6..v7:

* New - Replace older instances of assert with TEST_ASSERT for richer
  error reporing
---
 tools/testing/selftests/kvm/lib/x86/sev.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/testing/selftests/kvm/lib/x86/sev.c 
b/tools/testing/selftests/kvm/lib/x86/sev.c
index e9535ee20b7f..60d7a03dc1c2 100644
--- a/tools/testing/selftests/kvm/lib/x86/sev.c
+++ b/tools/testing/selftests/kvm/lib/x86/sev.c
@@ -37,12 +37,12 @@ static void encrypt_region(struct kvm_vm *vm, struct 
userspace_mem_region *regio
 void sev_vm_init(struct kvm_vm *vm)
 {
        if (vm->type == KVM_X86_DEFAULT_VM) {
-               assert(vm->arch.sev_fd == -1);
+               TEST_ASSERT_EQ(vm->arch.sev_fd, -1);
                vm->arch.sev_fd = open_sev_dev_path_or_exit();
                vm_sev_ioctl(vm, KVM_SEV_INIT, NULL);
        } else {
                struct kvm_sev_init init = { 0 };
-               assert(vm->type == KVM_X86_SEV_VM);
+               TEST_ASSERT_EQ(vm->type, KVM_X86_SEV_VM);
                vm_sev_ioctl(vm, KVM_SEV_INIT2, &init);
        }
 }
@@ -50,12 +50,12 @@ void sev_vm_init(struct kvm_vm *vm)
 void sev_es_vm_init(struct kvm_vm *vm)
 {
        if (vm->type == KVM_X86_DEFAULT_VM) {
-               assert(vm->arch.sev_fd == -1);
+               TEST_ASSERT_EQ(vm->arch.sev_fd, -1);
                vm->arch.sev_fd = open_sev_dev_path_or_exit();
                vm_sev_ioctl(vm, KVM_SEV_ES_INIT, NULL);
        } else {
                struct kvm_sev_init init = { 0 };
-               assert(vm->type == KVM_X86_SEV_ES_VM);
+               TEST_ASSERT_EQ(vm->type, KVM_X86_SEV_ES_VM);
                vm_sev_ioctl(vm, KVM_SEV_INIT2, &init);
        }
 }
-- 
2.43.0


Reply via email to