在 2025/2/19 下午3:48, Paul Menzel 写道:
Dear Qunqin,


Thank you for your patch, and for wanting to maintain this code. Two minor things should you resend:

I found it quite useful to have the maintainer name in the summary/title as often only the `git log --oneline` output is used in change-logs. I suggest:

MAINTAINERS: Add Qunqin Zhao for new Loongson Security Module driver

Hi, Paul,  thanks for your comments.

I took a look at the git log of MAINTAINERS file.  It is rare to put the maintainer's name on the title when adding a new entry.

The usual practice should be "Add entry for Loongson Security Module driver".


Am 19.02.25 um 08:32 schrieb Qunqin Zhao:
This patch adds an entry for Loongson Security Module driver in the list
of Maintainers.

Maintainers could be spelled lowercase.

OK.

BR, Qunqin.


Signed-off-by: Qunqin Zhao <zhaoqun...@loongson.cn>
---
  MAINTAINERS | 7 +++++++
  1 file changed, 7 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5583df569c..cd6c029398 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13494,6 +13494,13 @@ S:    Maintained
  F: Documentation/devicetree/bindings/i2c/loongson,ls2x-i2c.yaml
  F:    drivers/i2c/busses/i2c-ls2x.c
  +LOONGSON SECURITY MODULE DRIVER
+M:    Qunqin Zhao <zhaoqun...@loongson.cn>
+L:    loonga...@lists.linux.dev
+S:    Maintained
+F:    drivers/mfd/ls6000se.c
+F:    include/linux/mfd/ls6000se.h
+
  LOONGSON-2 SOC SERIES CLOCK DRIVER
  M:    Yinbo Zhu <zhuyi...@loongson.cn>
  L:    linux-...@vger.kernel.org


Kind regards,

Paul


Reply via email to