Re: [RFC PATCH v3 03/13] clavis: Introduce a new system keyring called clavis

[Jarkko Sakkinen]

On Thu, 2024-10-17 at 09:55 -0600, Eric Snowberg wrote:
> +static struct asymmetric_key_id *clavis_parse_boot_param(char *kid,
> struct asymmetric_key_id *akid,
> +                                                      int
> akid_max_len)
> +{
> +     int error, hex_len;
> +
> +     if (!kid)
> +             return 0;
> +
> +     hex_len = strlen(kid) / 2;

Hmmm... I'd consider sanity checking this:

        size_t len;

        /* ... */

        len = strlen(kid);
        if (len % 2) {
                pr_err("Clavis key id has invalid length %lu\n", len);
                return 0;
        }

        hex_len = len / 2;
        
BR, Jarkko