> -----Original Message----- > From: Markus Elfring [mailto:markus.elfr...@web.de] > Sent: Tuesday, December 26, 2023 6:12 PM > To: kernel test robot <l...@intel.com>; virtualizat...@lists.linux.dev; > linux-crypto@vger.kernel.org; kernel-janit...@vger.kernel.org; David S. Miller > <da...@davemloft.net>; Gonglei (Arei) <arei.gong...@huawei.com>; Herbert > Xu <herb...@gondor.apana.org.au>; Jason Wang <jasow...@redhat.com>; > Michael S. Tsirkin <m...@redhat.com>; Xuan Zhuo > <xuanz...@linux.alibaba.com> > Cc: l...@lists.linux.dev; oe-kbuild-...@lists.linux.dev; > net...@vger.kernel.org; > LKML <linux-ker...@vger.kernel.org>; co...@inria.fr > Subject: [PATCH v2] crypto: virtio - Less function calls in > __virtio_crypto_akcipher_do_req() after error detection > > From: Markus Elfring <elfr...@users.sourceforge.net> > Date: Tue, 26 Dec 2023 11:00:20 +0100 > > The kfree() function was called in up to two cases by the > __virtio_crypto_akcipher_do_req() function during error handling even if the > passed variable contained a null pointer. > This issue was detected by using the Coccinelle software. > > * Adjust jump targets. > > * Delete two initialisations which became unnecessary > with this refactoring. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> > --- > > v2: > A typo was fixed for the delimiter of a label. > > drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >
Reviewed-by: Gonglei <arei.gong...@huawei.com> Regards, -Gonglei
