pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushix...@huawei.com>
---
 drivers/crypto/stm32/stm32-cryp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/crypto/stm32/stm32-cryp.c 
b/drivers/crypto/stm32/stm32-cryp.c
index 2a4793176c71..7389a0536ff0 100644
--- a/drivers/crypto/stm32/stm32-cryp.c
+++ b/drivers/crypto/stm32/stm32-cryp.c
@@ -542,7 +542,7 @@ static int stm32_cryp_hw_init(struct stm32_cryp *cryp)
        int ret;
        u32 cfg, hw_mode;
 
-       pm_runtime_get_sync(cryp->dev);
+       pm_runtime_resume_and_get(cryp->dev);
 
        /* Disable interrupt */
        stm32_cryp_write(cryp, CRYP_IMSCR, 0);
@@ -2043,7 +2043,7 @@ static int stm32_cryp_remove(struct platform_device *pdev)
        if (!cryp)
                return -ENODEV;
 
-       ret = pm_runtime_get_sync(cryp->dev);
+       ret = pm_runtime_resume_and_get(cryp->dev);
        if (ret < 0)
                return ret;
 
-- 
2.25.1

Reply via email to