Herbert, On Fri, Jan 29, 2021 at 02:00:04PM +1100, Herbert Xu wrote: > On Thu, Jan 28, 2021 at 09:49:41PM -0500, Stefan Berger wrote: > > > > In my patch series I initially had registered the akciphers under the names > > ecc-nist-p192 and ecc-nist-p256 but now, in V4, joined them together as > > 'ecdsa'. This may be too generic for a name. Maybe it should be called > > ecsda-nist for the NIST family. > > What I'm proposing is specifying the curve in the name as well, i.e., > ecdsa-nist-p192 instead of just ecdsa or ecdsa-nist. > > This simplifies the task of handling hardware that only supports a > subset of curves.
So, if some implementation supports multiple curves (like EC-RDSA currently supports 5 curves), it should add 5 ecrdsa-{a,b,c,..} algorithms with actually the same top level implementation? Right? > There is a parallel discussion of exactly what curves we should > support in the kernel. Personally if there is a user in the kernel > for it then I'm happy to see it added. In your specific case, as > long as your use of the algorithm in x509 is accepted then I don't > have any problems with adding support in the Crypto API. > > Cheers, > -- > Email: Herbert Xu <herb...@gondor.apana.org.au> > Home Page: http://gondor.apana.org.au/~herbert/ > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt