The return value of qat_hal_rd_ae_csr() is always a CSR value and never
a status and should not be stored in the status variable of
qat_hal_put_rel_rd_xfer().

This removes the assignment as qat_hal_rd_ae_csr() is not expected to
fail.
A more comprehensive handling of the theoretical corner case which could
result in a fail will be submitted in a separate patch.

Fixes: 8c9478a400b7 ("crypto: qat - reduce stack size with KASAN")
Signed-off-by: Jack Xu <jack...@intel.com>
Reviewed-by: Giovanni Cabiddu <giovanni.cabi...@intel.com>
Reviewed-by: Fiona Trahe <fiona.tr...@intel.com>
---
 drivers/crypto/qat/qat_common/qat_hal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/qat/qat_common/qat_hal.c 
b/drivers/crypto/qat/qat_common/qat_hal.c
index bc07199459e7..5da8475ed876 100644
--- a/drivers/crypto/qat/qat_common/qat_hal.c
+++ b/drivers/crypto/qat/qat_common/qat_hal.c
@@ -1149,7 +1149,7 @@ static int qat_hal_put_rel_rd_xfer(struct 
icp_qat_fw_loader_handle *handle,
        unsigned short mask;
        unsigned short dr_offset = 0x10;
 
-       status = ctx_enables = qat_hal_rd_ae_csr(handle, ae, CTX_ENABLES);
+       ctx_enables = qat_hal_rd_ae_csr(handle, ae, CTX_ENABLES);
        if (CE_INUSE_CONTEXTS & ctx_enables) {
                if (ctx & 0x1) {
                        pr_err("QAT: bad 4-ctx mode,ctx=0x%x\n", ctx);
-- 
2.25.4

Reply via email to