From: Nick Terrell <terre...@fb.com>

Move away from the compatibility wrapper to the zstd-1.4.6 API. This
code is functionally equivalent.

Signed-off-by: Nick Terrell <terre...@fb.com>
---
 fs/btrfs/zstd.c | 48 ++++++++++++++++++++++++++++--------------------
 1 file changed, 28 insertions(+), 20 deletions(-)

diff --git a/fs/btrfs/zstd.c b/fs/btrfs/zstd.c
index a7367ff573d4..6b466e090cd7 100644
--- a/fs/btrfs/zstd.c
+++ b/fs/btrfs/zstd.c
@@ -16,7 +16,7 @@
 #include <linux/refcount.h>
 #include <linux/sched.h>
 #include <linux/slab.h>
-#include <linux/zstd_compat.h>
+#include <linux/zstd.h>
 #include "misc.h"
 #include "compression.h"
 #include "ctree.h"
@@ -159,8 +159,8 @@ static void zstd_calc_ws_mem_sizes(void)
                        zstd_get_btrfs_parameters(level, ZSTD_BTRFS_MAX_INPUT);
                size_t level_size =
                        max_t(size_t,
-                             ZSTD_CStreamWorkspaceBound(params.cParams),
-                             ZSTD_DStreamWorkspaceBound(ZSTD_BTRFS_MAX_INPUT));
+                             
ZSTD_estimateCStreamSize_usingCParams(params.cParams),
+                             ZSTD_estimateDStreamSize(ZSTD_BTRFS_MAX_INPUT));
 
                max_size = max_t(size_t, max_size, level_size);
                zstd_ws_mem_sizes[level - 1] = max_size;
@@ -389,13 +389,23 @@ int zstd_compress_pages(struct list_head *ws, struct 
address_space *mapping,
        *total_in = 0;
 
        /* Initialize the stream */
-       stream = ZSTD_initCStream(params, len, workspace->mem,
-                       workspace->size);
+       stream = ZSTD_initStaticCStream(workspace->mem, workspace->size);
        if (!stream) {
-               pr_warn("BTRFS: ZSTD_initCStream failed\n");
+               pr_warn("BTRFS: ZSTD_initStaticCStream failed\n");
                ret = -EIO;
                goto out;
        }
+       {
+               size_t ret2;
+
+               ret2 = ZSTD_initCStream_advanced(stream, NULL, 0, params, len);
+               if (ZSTD_isError(ret2)) {
+                       pr_warn("BTRFS: ZSTD_initCStream_advanced returned 
%s\n",
+                                       ZSTD_getErrorName(ret2));
+                       ret = -EIO;
+                       goto out;
+               }
+       }
 
        /* map in the first page of input data */
        in_page = find_get_page(mapping, start >> PAGE_SHIFT);
@@ -421,8 +431,8 @@ int zstd_compress_pages(struct list_head *ws, struct 
address_space *mapping,
                ret2 = ZSTD_compressStream(stream, &workspace->out_buf,
                                &workspace->in_buf);
                if (ZSTD_isError(ret2)) {
-                       pr_debug("BTRFS: ZSTD_compressStream returned %d\n",
-                                       ZSTD_getErrorCode(ret2));
+                       pr_debug("BTRFS: ZSTD_compressStream returned %s\n",
+                                       ZSTD_getErrorName(ret2));
                        ret = -EIO;
                        goto out;
                }
@@ -489,8 +499,8 @@ int zstd_compress_pages(struct list_head *ws, struct 
address_space *mapping,
 
                ret2 = ZSTD_endStream(stream, &workspace->out_buf);
                if (ZSTD_isError(ret2)) {
-                       pr_debug("BTRFS: ZSTD_endStream returned %d\n",
-                                       ZSTD_getErrorCode(ret2));
+                       pr_debug("BTRFS: ZSTD_endStream returned %s\n",
+                                       ZSTD_getErrorName(ret2));
                        ret = -EIO;
                        goto out;
                }
@@ -557,10 +567,9 @@ int zstd_decompress_bio(struct list_head *ws, struct 
compressed_bio *cb)
        unsigned long buf_start;
        unsigned long total_out = 0;
 
-       stream = ZSTD_initDStream(
-                       ZSTD_BTRFS_MAX_INPUT, workspace->mem, workspace->size);
+       stream = ZSTD_initStaticDStream(workspace->mem, workspace->size);
        if (!stream) {
-               pr_debug("BTRFS: ZSTD_initDStream failed\n");
+               pr_debug("BTRFS: ZSTD_initStaticDStream failed\n");
                ret = -EIO;
                goto done;
        }
@@ -579,8 +588,8 @@ int zstd_decompress_bio(struct list_head *ws, struct 
compressed_bio *cb)
                ret2 = ZSTD_decompressStream(stream, &workspace->out_buf,
                                &workspace->in_buf);
                if (ZSTD_isError(ret2)) {
-                       pr_debug("BTRFS: ZSTD_decompressStream returned %d\n",
-                                       ZSTD_getErrorCode(ret2));
+                       pr_debug("BTRFS: ZSTD_decompressStream returned %s\n",
+                                       ZSTD_getErrorName(ret2));
                        ret = -EIO;
                        goto done;
                }
@@ -633,10 +642,9 @@ int zstd_decompress(struct list_head *ws, unsigned char 
*data_in,
        unsigned long pg_offset = 0;
        char *kaddr;
 
-       stream = ZSTD_initDStream(
-                       ZSTD_BTRFS_MAX_INPUT, workspace->mem, workspace->size);
+       stream = ZSTD_initStaticDStream(workspace->mem, workspace->size);
        if (!stream) {
-               pr_warn("BTRFS: ZSTD_initDStream failed\n");
+               pr_warn("BTRFS: ZSTD_initStaticDStream failed\n");
                ret = -EIO;
                goto finish;
        }
@@ -667,8 +675,8 @@ int zstd_decompress(struct list_head *ws, unsigned char 
*data_in,
                ret2 = ZSTD_decompressStream(stream, &workspace->out_buf,
                                &workspace->in_buf);
                if (ZSTD_isError(ret2)) {
-                       pr_debug("BTRFS: ZSTD_decompressStream returned %d\n",
-                                       ZSTD_getErrorCode(ret2));
+                       pr_debug("BTRFS: ZSTD_decompressStream returned %s\n",
+                                       ZSTD_getErrorName(ret2));
                        ret = -EIO;
                        goto finish;
                }
-- 
2.28.0

Reply via email to