On 8/31/2020 10:58 AM, Andy Shevchenko wrote:
Use traditional error check pattern
        ret = ...;
        if (ret)
                return ret;
        ...
instead of checking error code to be 0.

Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>

Reviewed-by: Iuliana Prodan <iuliana.pro...@nxp.com>

---
  drivers/crypto/caam/ctrl.c | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
index 65de57f169d9..25785404a58e 100644
--- a/drivers/crypto/caam/ctrl.c
+++ b/drivers/crypto/caam/ctrl.c
@@ -333,11 +333,10 @@ static int instantiate_rng(struct device *ctrldev, int 
state_handle_mask,
kfree(desc); - if (!ret)
-               ret = devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng,
-                                              ctrldev);
+       if (ret)
+               return ret;
- return ret;
+       return devm_add_action_or_reset(ctrldev, devm_deinstantiate_rng, 
ctrldev);
  }
/*

Reply via email to