Re: [PATCH 2/2] crypto: Ingenic: Add hardware RNG for Ingenic JZ4780 and X1000.

[Zhou Yanjie]

Hello Randy,

在 2020/7/23 上午2:27, Randy Dunlap 写道:

On 7/22/20 9:40 AM, 周琰杰 (Zhou Yanjie) wrote:

diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
index 0ad17efc96df..fcb06027cd88 100644
--- a/drivers/char/hw_random/Kconfig
+++ b/drivers/char/hw_random/Kconfig
@@ -257,6 +257,21 @@ config HW_RANDOM_IMX_RNGC

If unsure, say Y. +config HW_RANDOM_INGENIC_RNG

+       tristate "Ingenic Random Number Generator support"
+       depends on HW_RANDOM
+       depends on MACH_JZ4780 || MACH_X1000
+       default HW_RANDOM
+       ---help---

Just use:
        help
here. See this for why:

commit 8f268881d7d278047b00eed54bbb9288dbd6ab23
Author: Masahiro Yamada <masahi...@kernel.org>
Date:   Tue Dec 17 20:51:51 2019 +0900

     kconfig: remove ---help--- from documentation

Since commit 84af7a6194e4 ("checkpatch: kconfig: prefer 'help' over

     '---help---'"), scripts/checkpatch.pl warns the use of ---help---.

Kconfig still supports ---help---, but new code should avoid using it.

     Let's stop advertising it in documentation.

Sure, I will change it in v2.

Thanks and best regards!

+         This driver provides kernel-side support for the Random Number 
Generator
+         hardware found in ingenic JZ4780 and X1000 SoC. MIPS Creator CI20 uses
+         JZ4780 SoC, YSH & ATIL CU1000-Neo uses X1000 SoC.
+
+         To compile this driver as a module, choose M here: the
+         module will be called ingenic-rng.
+
+         If unsure, say Y.
+
  config HW_RANDOM_NOMADIK
        tristate "ST-Ericsson Nomadik Random Number Generator support"
        depends on ARCH_NOMADIK

thanks.