> -----Original Message-----
> From: Herbert Xu [mailto:herb...@gondor.apana.org.au]
> Sent: Friday, July 3, 2020 4:11 PM
> To: Song Bao Hua (Barry Song) <song.bao....@hisilicon.com>
> Cc: da...@davemloft.net; Wangzhou (B) <wangzh...@hisilicon.com>;
> Jonathan Cameron <jonathan.came...@huawei.com>;
> a...@linux-foundation.org; linux-crypto@vger.kernel.org;
> linux...@kvack.org; linux-ker...@vger.kernel.org; Linuxarm
> <linux...@huawei.com>; Seth Jennings <sjenn...@redhat.com>; Dan
> Streetman <ddstr...@ieee.org>; Vitaly Wool <vitaly.w...@konsulko.com>
> Subject: Re: [PATCH v2 1/3] crypto: permit users to specify numa node of
> acomp hardware
> 
> On Tue, Jun 23, 2020 at 04:16:08PM +1200, Barry Song wrote:
> >
> > -void *crypto_create_tfm(struct crypto_alg *alg,
> > -                   const struct crypto_type *frontend)
> > +void *crypto_create_tfm_node(struct crypto_alg *alg,
> > +                   const struct crypto_type *frontend,
> > +                   int node)
> >  {
> >     char *mem;
> >     struct crypto_tfm *tfm = NULL;
> > @@ -451,6 +452,7 @@ void *crypto_create_tfm(struct crypto_alg *alg,
> >
> >     tfm = (struct crypto_tfm *)(mem + tfmsize);
> >     tfm->__crt_alg = alg;
> > +   tfm->node = node;
> 
> Should the kzalloc also use node?

Yes, it would be nice since the tfm will mainly be accessed by CPU on the 
specific node.

> 
> Thanks,
> --
> Email: Herbert Xu <herb...@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Thanks
Barry

Reply via email to