On Mon, Jun 15, 2020 at 11:50:28AM -0700, Eric Biggers wrote: > > Wouldn't it make a lot more sense to make skcipher algorithms non-chainable by > default, and only opt-in the ones where chaining is actually working? At the > moment we only test iv_out for CBC and CTR, so we can expect that all the > others > are broken.
Yes, I'm working through all the algorithms marking them. If it turns out that defaulting to off would result in a smaller patch then I'm certainly going to do that. > Note that wide-block modes such as Adiantum don't support chaining either. > > Also, please use a better name than "fcsize". Any suggestions? Thanks, -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
