Re: [PATCH] crypto: omap-des - Fix sparse/compiler warnings

[Tero Kristo]

On 15/06/2020 14:36, Herbert Xu wrote:

This patch fixes sparse endianness warnings as well as compiler
warnings on 64-bit hosts.

Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>

Looks fine to me:

Reviewed-by: Tero Kristo <t-kri...@ti.com>

diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index 8eda43319204..c9d38bcfd1c7 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -87,7 +87,7 @@ struct omap_des_ctx {
        struct omap_des_dev *dd;

int keylen;

-       u32             key[(3 * DES_KEY_SIZE) / sizeof(u32)];
+       __le32          key[(3 * DES_KEY_SIZE) / sizeof(u32)];
        unsigned long   flags;
  };

@@ -461,7 +461,7 @@ static int omap_des_crypt_dma_start(struct omap_des_dev *dd)

                                        crypto_skcipher_reqtfm(dd->req));
        int err;

- pr_debug("total: %d\n", dd->total);

+       pr_debug("total: %zd\n", dd->total);

if (!dd->pio_only) {

                err = dma_map_sg(dd->dev, dd->in_sg, dd->in_sg_len,
@@ -504,7 +504,7 @@ static void omap_des_finish_req(struct omap_des_dev *dd, 
int err)

static int omap_des_crypt_dma_stop(struct omap_des_dev *dd)

  {
-       pr_debug("total: %d\n", dd->total);
+       pr_debug("total: %zd\n", dd->total);

omap_des_dma_stop(dd);

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. 
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki