On Fri, Jun 05, 2020 at 02:03:39PM +0300, Dan Carpenter wrote:
> Smatch reports that:
>
> drivers/crypto/marvell/octeontx/otx_cptvf_algs.c:132
> otx_cpt_aead_callback()
> warn: variable dereferenced before check 'cpt_info' (see line 121)
>
> This function is called from process_pending_queue() as:
>
> drivers/crypto/marvell/octeontx/otx_cptvf_reqmgr.c
> 599 /*
> 600 * Call callback after current pending entry has been
> 601 * processed, we don't do it if the callback pointer
> is
> 602 * invalid.
> 603 */
> 604 if (callback)
> 605 callback(res_code, areq, cpt_info);
>
> It does appear to me that "cpt_info" can be NULL so this could lead to
> a NULL dereference.
>
> Fixes: 10b4f09491bf ("crypto: marvell - add the Virtual Function driver for
> CPT")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> drivers/crypto/marvell/octeontx/otx_cptvf_algs.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
