On Wed, Oct 02, 2019 at 04:17:07PM +0200, Ard Biesheuvel wrote: > - replace .c #includes with Kconfig based object selection
Cool! > +config CRYPTO_ARCH_HAVE_LIB_CURVE25519 > + tristate > + > +config CRYPTO_ARCH_HAVE_LIB_CURVE25519_BASE > + bool > + > +config CRYPTO_LIB_CURVE25519 > + tristate "Curve25519 scalar multiplication library" > + depends on CRYPTO_ARCH_HAVE_LIB_CURVE25519 || > !CRYPTO_ARCH_HAVE_LIB_CURVE25519 a || !a ==> true Did you mean for one of these to be _BASE? Or is this a Kconfig trick of a different variety that's intentional? > +libcurve25519-y := curve25519-fiat32.o > +libcurve25519-$(CONFIG_ARCH_SUPPORTS_INT128) := curve25519-hacl64.o Nice idea.
