On Fri, Aug 02, 2019 at 09:28:04PM +0800, YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
> 
> Reported-by: Hulk Robot <hul...@huawei.com>
> Signed-off-by: YueHaibing <yuehaib...@huawei.com>

Acked-by: Jamie Iles <ja...@jamieiles.com>

> ---
>  drivers/crypto/picoxcell_crypto.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/crypto/picoxcell_crypto.c 
> b/drivers/crypto/picoxcell_crypto.c
> index b985cb85..9a939b4 100644
> --- a/drivers/crypto/picoxcell_crypto.c
> +++ b/drivers/crypto/picoxcell_crypto.c
> @@ -1624,7 +1624,7 @@ MODULE_DEVICE_TABLE(of, spacc_of_id_table);
>  static int spacc_probe(struct platform_device *pdev)
>  {
>       int i, err, ret;
> -     struct resource *mem, *irq;
> +     struct resource *irq;
>       struct device_node *np = pdev->dev.of_node;
>       struct spacc_engine *engine = devm_kzalloc(&pdev->dev, sizeof(*engine),
>                                                  GFP_KERNEL);
> @@ -1653,8 +1653,7 @@ static int spacc_probe(struct platform_device *pdev)
>  
>       engine->name = dev_name(&pdev->dev);
>  
> -     mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -     engine->regs = devm_ioremap_resource(&pdev->dev, mem);
> +     engine->regs = devm_platform_ioremap_resource(pdev, 0);
>       if (IS_ERR(engine->regs))
>               return PTR_ERR(engine->regs);
>  
> -- 
> 2.7.4
> 
> 

Reply via email to