On Wed, Jul 31, 2019 at 01:48:33AM +0530, Amit Pundir wrote:
> From: Wen Yang <wen.yan...@zte.com.cn>
>
> commit 95566aa75cd6b3b404502c06f66956b5481194b3 upstream.
>
> There is a possible double free issue in ppc4xx_trng_probe():
>
> 85: dev->trng_base = of_iomap(trng, 0);
> 86: of_node_put(trng); ---> released here
> 87: if (!dev->trng_base)
> 88: goto err_out;
> ...
> 110: ierr_out:
> 111: of_node_put(trng); ---> double released here
> ...
>
> This issue was detected by using the Coccinelle software.
> We fix it by removing the unnecessary of_node_put().
>
> Fixes: 5343e674f32f ("crypto4xx: integrate ppc4xx-rng into crypto4xx")
> Signed-off-by: Wen Yang <wen.yan...@zte.com.cn>
> Cc: <sta...@vger.kernel.org>
> Cc: "David S. Miller" <da...@davemloft.net>
> Cc: Thomas Gleixner <t...@linutronix.de>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: Allison Randal <alli...@lohutok.net>
> Cc: Armijn Hemel <arm...@tjaldur.nl>
> Cc: Julia Lawall <julia.law...@lip6.fr>
> Cc: linux-crypto@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> Acked-by: Julia Lawall <julia.law...@lip6.fr>
> Signed-off-by: Herbert Xu <herb...@gondor.apana.org.au>
> Signed-off-by: Amit Pundir <amit.pun...@linaro.org>
> ---
> Cleanly apply on 4.9.y as well.
This is already in the 4.14.135 kernel release. Are you sure we need it
there again?
thanks,
greg k-h
