Signed-off-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
---
 arch/sparc/crypto/des_glue.c | 35 +++++++++-----------
 1 file changed, 15 insertions(+), 20 deletions(-)

diff --git a/arch/sparc/crypto/des_glue.c b/arch/sparc/crypto/des_glue.c
index 453a4cf5492a..8a35491d6656 100644
--- a/arch/sparc/crypto/des_glue.c
+++ b/arch/sparc/crypto/des_glue.c
@@ -11,7 +11,7 @@
 #include <linux/mm.h>
 #include <linux/types.h>
 #include <crypto/algapi.h>
-#include <crypto/des.h>
+#include <crypto/internal/des.h>
 
 #include <asm/fpumacro.h>
 #include <asm/pstate.h>
@@ -44,19 +44,15 @@ static int des_set_key(struct crypto_tfm *tfm, const u8 
*key,
                       unsigned int keylen)
 {
        struct des_sparc64_ctx *dctx = crypto_tfm_ctx(tfm);
-       u32 *flags = &tfm->crt_flags;
-       u32 tmp[DES_EXPKEY_WORDS];
-       int ret;
+       int err;
 
        /* Even though we have special instructions for key expansion,
-        * we call des_ekey() so that we don't have to write our own
+        * we call des_verify_key() so that we don't have to write our own
         * weak key detection code.
         */
-       ret = des_ekey(tmp, key);
-       if (unlikely(ret == 0) && (*flags & CRYPTO_TFM_REQ_FORBID_WEAK_KEYS)) {
-               *flags |= CRYPTO_TFM_RES_WEAK_KEY;
-               return -EINVAL;
-       }
+       err = crypto_des_verify_key(tfm, key);
+       if (unlikely(err))
+               return err;
 
        des_sparc64_key_expand((const u32 *) key, &dctx->encrypt_expkey[0]);
        encrypt_to_decrypt(&dctx->decrypt_expkey[0], &dctx->encrypt_expkey[0]);
@@ -67,7 +63,7 @@ static int des_set_key(struct crypto_tfm *tfm, const u8 *key,
 extern void des_sparc64_crypt(const u64 *key, const u64 *input,
                              u64 *output);
 
-static void des_encrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
+static void crypto_des_encrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
 {
        struct des_sparc64_ctx *ctx = crypto_tfm_ctx(tfm);
        const u64 *K = ctx->encrypt_expkey;
@@ -75,7 +71,7 @@ static void des_encrypt(struct crypto_tfm *tfm, u8 *dst, 
const u8 *src)
        des_sparc64_crypt(K, (const u64 *) src, (u64 *) dst);
 }
 
-static void des_decrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
+static void crypto_des_decrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
 {
        struct des_sparc64_ctx *ctx = crypto_tfm_ctx(tfm);
        const u64 *K = ctx->decrypt_expkey;
@@ -201,13 +197,12 @@ static int des3_ede_set_key(struct crypto_tfm *tfm, const 
u8 *key,
                            unsigned int keylen)
 {
        struct des3_ede_sparc64_ctx *dctx = crypto_tfm_ctx(tfm);
-       u32 *flags = &tfm->crt_flags;
        u64 k1[DES_EXPKEY_WORDS / 2];
        u64 k2[DES_EXPKEY_WORDS / 2];
        u64 k3[DES_EXPKEY_WORDS / 2];
        int err;
 
-       err = __des3_verify_key(flags, key);
+       err = crypto_des3_ede_verify_key(tfm, key);
        if (unlikely(err))
                return err;
 
@@ -234,7 +229,7 @@ static int des3_ede_set_key(struct crypto_tfm *tfm, const 
u8 *key,
 extern void des3_ede_sparc64_crypt(const u64 *key, const u64 *input,
                                   u64 *output);
 
-static void des3_ede_encrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
+static void crypto_des3_ede_encrypt(struct crypto_tfm *tfm, u8 *dst, const u8 
*src)
 {
        struct des3_ede_sparc64_ctx *ctx = crypto_tfm_ctx(tfm);
        const u64 *K = ctx->encrypt_expkey;
@@ -242,7 +237,7 @@ static void des3_ede_encrypt(struct crypto_tfm *tfm, u8 
*dst, const u8 *src)
        des3_ede_sparc64_crypt(K, (const u64 *) src, (u64 *) dst);
 }
 
-static void des3_ede_decrypt(struct crypto_tfm *tfm, u8 *dst, const u8 *src)
+static void crypto_des3_ede_decrypt(struct crypto_tfm *tfm, u8 *dst, const u8 
*src)
 {
        struct des3_ede_sparc64_ctx *ctx = crypto_tfm_ctx(tfm);
        const u64 *K = ctx->decrypt_expkey;
@@ -389,8 +384,8 @@ static struct crypto_alg algs[] = { {
                        .cia_min_keysize        = DES_KEY_SIZE,
                        .cia_max_keysize        = DES_KEY_SIZE,
                        .cia_setkey             = des_set_key,
-                       .cia_encrypt            = des_encrypt,
-                       .cia_decrypt            = des_decrypt
+                       .cia_encrypt            = crypto_des_encrypt,
+                       .cia_decrypt            = crypto_des_decrypt
                }
        }
 }, {
@@ -446,8 +441,8 @@ static struct crypto_alg algs[] = { {
                        .cia_min_keysize        = DES3_EDE_KEY_SIZE,
                        .cia_max_keysize        = DES3_EDE_KEY_SIZE,
                        .cia_setkey             = des3_ede_set_key,
-                       .cia_encrypt            = des3_ede_encrypt,
-                       .cia_decrypt            = des3_ede_decrypt
+                       .cia_encrypt            = crypto_des3_ede_encrypt,
+                       .cia_decrypt            = crypto_des3_ede_decrypt
                }
        }
 }, {
-- 
2.20.1

Reply via email to