On Tue, May 28, 2019 at 01:41:52PM +0100, Elena Petrova wrote: > The sha1-ce finup implementation for ARM64 produces wrong digest > for empty input (len=0). Expected: da39a3ee..., result: 67452301... > (initial value of SHA internal state). The error is in sha1_ce_finup: > for empty data `finalize` will be 1, so the code is relying on > sha1_ce_transform to make the final round. However, in > sha1_base_do_update, the block function will not be called when > len == 0. > > Fix it by setting finalize to 0 if data is empty. > > Fixes: 07eb54d306f4 ("crypto: arm64/sha1-ce - move SHA-1 ARMv8 implementation > to base layer") > Cc: sta...@vger.kernel.org > Signed-off-by: Elena Petrova <lena...@google.com> > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > --- > arch/arm64/crypto/sha1-ce-glue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks. -- Email: Herbert Xu <herb...@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt