sparse complains thusly:

  CHECK   arch/x86/crypto/morus640-sse2-glue.c
arch/x86/crypto/morus640-sse2-glue.c:38:1: warning: symbol 
'crypto_morus640_sse2_algs' was not declared. Should it be static?
  CHECK   arch/x86/crypto/morus1280-sse2-glue.c
arch/x86/crypto/morus1280-sse2-glue.c:38:1: warning: symbol 
'crypto_morus1280_sse2_algs' was not declared. Should it be static?
  CHECK   arch/x86/crypto/morus1280-avx2-glue.c
arch/x86/crypto/morus1280-avx2-glue.c:38:1: warning: symbol 
'crypto_morus1280_avx2_algs' was not declared. Should it be static?

and sparse is correct - these don't need to be global and polluting the 
namespace.

Signed-off-by: Valdis Kletnieks <valdis.kletni...@vt.edu>
---
diff --git a/include/crypto/morus1280_glue.h b/include/crypto/morus1280_glue.h
index b26dd70efd9a..ba782e10065e 100644
--- a/include/crypto/morus1280_glue.h
+++ b/include/crypto/morus1280_glue.h
@@ -82,7 +82,7 @@ void cryptd_morus1280_glue_exit_tfm(struct crypto_aead *aead);
        { \
        } \
        \
-       struct aead_alg crypto_morus1280_##id##_algs[] = {\
+       static struct aead_alg crypto_morus1280_##id##_algs[] = {\
                { \
                        .setkey = crypto_morus1280_glue_setkey, \
                        .setauthsize = crypto_morus1280_glue_setauthsize, \
diff --git a/include/crypto/morus640_glue.h b/include/crypto/morus640_glue.h
index 90c8db07e740..27fa790a2362 100644
--- a/include/crypto/morus640_glue.h
+++ b/include/crypto/morus640_glue.h
@@ -82,7 +82,7 @@ void cryptd_morus640_glue_exit_tfm(struct crypto_aead *aead);
        { \
        } \
        \
-       struct aead_alg crypto_morus640_##id##_algs[] = {\
+       static struct aead_alg crypto_morus640_##id##_algs[] = {\
                { \
                        .setkey = crypto_morus640_glue_setkey, \
                        .setauthsize = crypto_morus640_glue_setauthsize, \

Reply via email to