Best Regards!
Anson Huang


> -----Original Message-----
> From: Fabio Estevam [mailto:feste...@gmail.com]
> Sent: 2018-01-09 5:27 PM
> To: Anson Huang <anson.hu...@nxp.com>
> Cc: Horia Geantă <horia.gea...@nxp.com>; Aymen Sghaier
> <aymen.sgha...@nxp.com>; Herbert Xu <herb...@gondor.apana.org.au>;
> David S. Miller <da...@davemloft.net>; Rob Herring <robh...@kernel.org>;
> Mark Rutland <mark.rutl...@arm.com>; Shawn Guo <shawn...@kernel.org>;
> Sascha Hauer <ker...@pengutronix.de>; Fabio Estevam
> <fabio.este...@nxp.com>; Russell King - ARM Linux <li...@armlinux.org.uk>;
> Michael Turquette <mturque...@baylibre.com>; Stephen Boyd
> <sb...@codeaurora.org>; Adriana Reus <adriana.r...@nxp.com>; Stefan
> Agner <ste...@agner.ch>; Dong Aisheng <donga...@gmail.com>; open
> list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
> <devicet...@vger.kernel.org>; linux-...@vger.kernel.org; linux-
> cry...@vger.kernel.org; moderated list:ARM/FREESCALE IMX / MXC ARM
> ARCHITECTURE <linux-arm-ker...@lists.infradead.org>; linux-kernel <linux-
> ker...@vger.kernel.org>
> Subject: Re: [PATCH V2 2/2] ARM: dts: imx7s: add snvs rtc clock
> 
> Hi Anson,
> 
> On Tue, Jan 9, 2018 at 12:51 AM, Anson Huang <anson.hu...@nxp.com>
> wrote:
> 
> > +   - clocks
> > +      Usage: required if SNVS LP RTC requires explicit enablement of clocks
> > +      Value type: <prop_encoded-array>
> > +      Definition:  A list of phandle and clock specifier pairs describing
> > +          the clocks required for enabling and disabling SNVS LP RTC.
> 
> 
> It is a single clock that is used here, so it would be better to describe the 
> text as:
> 
>       Definition:  A clock specifier describing the clock required for 
> enabling and
> disabling SNVS LP RTC
> 
> > +   - clock-names
> > +      Usage: required if SNVS LP RTC requires explicit enablement of clocks
> > +      Value type: <string>
> > +      Definition: A list of clock name strings in the same order as the
> > +          clocks property.
> 
> and here you must describe that the name should be "snvs-rtc":
> 
>       Definition: Clock name string should be "snvs-rtc".


Agree, thanks. Will resend the patch.

Anson.

Reply via email to